Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable_db_query_source is now on by default #8850

Closed
wants to merge 2 commits into from
Closed

enable_db_query_source is now on by default #8850

wants to merge 2 commits into from

Conversation

sentrivana
Copy link
Contributor

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

We'll be changing the default for the enable_db_query_source Python SDK option from False to True in getsentry/sentry-python#2629 -- updating the docs.

Extra resources

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 9:11am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 9:11am

@sentrivana sentrivana mentioned this pull request Jan 10, 2024
Closed
@vivianyentran
Copy link
Contributor

Can you update the note here as well? https://docs.sentry.io/product/performance/queries/#query-sources

@sentrivana sentrivana requested a review from a team as a code owner January 11, 2024 08:50
@sentrivana
Copy link
Contributor Author

@vivianyentran Updated!

gggritso
gggritso approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

vivianyentran
vivianyentran approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating!

@sentrivana
Copy link
Contributor Author

Thanks for the reviews, y'all -- will keep this open until we release the SDK that contains the change.

@sentrivana sentrivana mentioned this pull request Feb 1, 2024
Merged
3 tasks
@sentrivana
Copy link
Contributor Author

Closing in favor of #9014

@sentrivana sentrivana closed this Feb 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vivianyentran vivianyentran vivianyentran approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@shanamatthews shanamatthews shanamatthews approved these changes

@gggritso gggritso gggritso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sentrivana @vivianyentran @gggritso @shanamatthews @AbhiPrasad